Skip to content

gml-decoder: cover ISO 19139 codelist value decoding#541

Merged
azahnen merged 2 commits into
masterfrom
gml-19139-codelists
Jun 22, 2026
Merged

gml-decoder: cover ISO 19139 codelist value decoding#541
azahnen merged 2 commits into
masterfrom
gml-19139-codelists

Conversation

@cportele

Copy link
Copy Markdown
Contributor

A codelist-valued property whose value is wrapped in a gmd codelist element (e.g. <gmd:CI_RoleCode codeListValue="processor">processor</gmd:CI_RoleCode>) carries its value in the element text, not in an xlink:href. Add a focused decoder test asserting such a property decodes from the text content even when its schema declares a codelist constraint — which on its own would route an xlink:href as the value — and add that codelist constraint to the role property of the existing full-tree decode fixture so the broader test guards the same path.

A codelist-valued property whose value is wrapped in a gmd codelist element
(e.g. <gmd:CI_RoleCode codeListValue="processor">processor</gmd:CI_RoleCode>)
carries its value in the element text, not in an xlink:href. Add a focused
decoder test asserting such a property decodes from the text content even when
its schema declares a codelist constraint — which on its own would route an
xlink:href as the value — and add that codelist constraint to the role property
of the existing full-tree decode fixture so the broader test guards the same
path.
@cportele cportele requested a review from azahnen as a code owner June 19, 2026 10:28
@azahnen azahnen enabled auto-merge (squash) June 22, 2026 06:54
@azahnen azahnen merged commit 05907eb into master Jun 22, 2026
3 checks passed
@azahnen azahnen deleted the gml-19139-codelists branch June 22, 2026 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants